feat: doc mgrs can edit/remind action holders #7971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7971 +/- ##
==========================================
+ Coverage 88.78% 88.84% +0.05%
==========================================
Files 296 304 +8
Lines 41320 41544 +224
==========================================
+ Hits 36687 36910 +223
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands permissions for editing a document's action holders or sending a reminder email. Instead of AD / secretariat, allows document managers for the document's group to take these actions.
Fixes #3391, which asked for chairs rather than document managers. Given the discussion, I think this is a logical thing to do, but I can scale back to chairs only if that makes more sense.